Freya World
Would you like to react to this message? Create an account in a few clicks or log in to continue.
Freya World

Open Source Java Project
 
HomeHome  Latest imagesLatest images  SearchSearch  RegisterRegister  Log inLog in  

 

 Cencel Skill Chance doesn"t work

Go down 
2 posters
AuthorMessage
janiko




Posts : 33
Join date : 2011-05-29

Cencel Skill Chance doesn"t work Empty
PostSubject: Cencel Skill Chance doesn"t work   Cencel Skill Chance doesn"t work Icon_minitimeSun May 29, 2011 10:12 am

We Have to fix skill's 342, 1056, it's chance doesn't works ;(
Back to top Go down
Willow
Admin
Willow


Posts : 113
Join date : 2011-05-24

Cencel Skill Chance doesn"t work Empty
PostSubject: Re: Cencel Skill Chance doesn"t work   Cencel Skill Chance doesn"t work Icon_minitimeSun May 29, 2011 2:30 pm

Can you test if this skill handler works better?
http://www.2shared.com/file/osbQHuhi/Cancel.html
Back to top Go down
janiko




Posts : 33
Join date : 2011-05-29

Cencel Skill Chance doesn"t work Empty
PostSubject: re   Cencel Skill Chance doesn"t work Icon_minitimeSun May 29, 2011 8:34 pm

I will try it later
Back to top Go down
janiko




Posts : 33
Join date : 2011-05-29

Cencel Skill Chance doesn"t work Empty
PostSubject: Re skill   Cencel Skill Chance doesn"t work Icon_minitimeMon May 30, 2011 1:48 am

I tried but its same Skill 342 1056 chance is 100% it but in skill.xml there is written 25% ;(
If we will fix it quickly it would be great
Back to top Go down
Willow
Admin
Willow


Posts : 113
Join date : 2011-05-24

Cencel Skill Chance doesn"t work Empty
PostSubject: Re: Cencel Skill Chance doesn"t work   Cencel Skill Chance doesn"t work Icon_minitimeMon May 30, 2011 3:47 am

The problem is that 25% is the change of the effect to be canceled.
The current skill handler has
int count = skill.getMaxNegatedEffects();
so with many buffs the limit is always reached, meaning you always get max cancels on large buff count.

Chance must be 25% (XML part is correct)
but skill handler should have a random limit based on skill.getMaxNegatedEffects()
instead of always getting max cancel count (100%)

Fixed on http://trac.assembla.com/FreyaWorld/changeset/66
Back to top Go down
Sponsored content





Cencel Skill Chance doesn"t work Empty
PostSubject: Re: Cencel Skill Chance doesn"t work   Cencel Skill Chance doesn"t work Icon_minitime

Back to top Go down
 
Cencel Skill Chance doesn"t work
Back to top 
Page 1 of 1

Permissions in this forum:You cannot reply to topics in this forum
Freya World :: Development :: Bug Reports-
Jump to: